Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accordion): use max-height #6429

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(Accordion): use max-height #6429

merged 1 commit into from
Jan 22, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Jan 22, 2024


  • e2e-тесты
    - [ ] Unit-тесты
    - [ ] Дизайн-ревью
    - [ ] Документация фичи

Описание

margin-top при выставлении процентов берет значение от ширины, а не высоты

Изменения

Для фикса бага используем max-height, вместо margin-top

margin-top при выставлении процентов берет значение от ширины, а не высоты
Для фикса бага используем max-height, вместо margin-top

- Fixes #6414
@SevereCloud SevereCloud requested a review from a team as a code owner January 22, 2024 09:34
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 22, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 347.92 KB (-0.01% 🔽)
JS (gzip) 106.42 KB (-0.02% 🔽)
JS (brotli) 88.01 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 256.42 KB (-0.01% 🔽)
CSS (gzip) 33.6 KB (-0.01% 🔽)
CSS (brotli) 27.3 KB (+0.03% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1784b6e:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 1784b6e

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8ec3b00) 81.36% compared to head (1784b6e) 81.35%.
Report is 3 commits behind head on master.

Files Patch % Lines
...vkui/src/components/Accordion/AccordionContent.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6429      +/-   ##
==========================================
- Coverage   81.36%   81.35%   -0.01%     
==========================================
  Files         327      327              
  Lines       10140    10139       -1     
  Branches     3412     3411       -1     
==========================================
- Hits         8250     8249       -1     
  Misses       1890     1890              
Flag Coverage Δ
unittests 81.35% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit a261ad2 into master Jan 22, 2024
26 of 27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6414 branch January 22, 2024 11:57
vkcom-publisher pushed a commit that referenced this pull request Jan 22, 2024
margin-top при выставлении процентов берет значение от ширины, а не высоты
Для фикса бага используем max-height, вместо margin-top

- Fixes #6414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Контент в Accordion перестает скрываться
3 participants