Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleCell): corrects the NVDA readings #6436

Closed
wants to merge 4 commits into from

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Jan 22, 2024

создание песочницы для тестирования a11y

@inomdzhon inomdzhon added type:bug cmp:simple-cell a11y Доступность (цифровая) labels Jan 22, 2024
@inomdzhon inomdzhon self-assigned this Jan 22, 2024
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 22, 2024
Copy link
Contributor

github-actions bot commented Jan 22, 2024

size-limit report 📦

Path Size
JS 348.35 KB (+0.02% 🔺)
JS (gzip) 106.54 KB (+0.02% 🔺)
JS (brotli) 88.15 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 256.63 KB (0%)
CSS (gzip) 33.63 KB (0%)
CSS (brotli) 27.32 KB (0%)

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9aa4526:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Jan 22, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jan 22, 2024

👀 Docs deployed

Commit 9aa4526

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b1c92d) 81.36% compared to head (9aa4526) 81.98%.
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6436      +/-   ##
==========================================
+ Coverage   81.36%   81.98%   +0.62%     
==========================================
  Files         327      327              
  Lines       10140    10136       -4     
  Branches     3412     3413       +1     
==========================================
+ Hits         8250     8310      +60     
+ Misses       1890     1826      -64     
Flag Coverage Δ
unittests 81.98% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon closed this Jan 25, 2024
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/SimpleCell-screen-reader branch January 25, 2024 09:10
@inomdzhon inomdzhon restored the imirdzhamolov/fix/SimpleCell-screen-reader branch January 25, 2024 09:10
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/SimpleCell-screen-reader branch January 25, 2024 09:10
@inomdzhon inomdzhon removed type:bug cmp:simple-cell a11y Доступность (цифровая) patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant