Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TabsItem): add anchor attributes #6439

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

SevereCloud
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи (типизация)

Описание

Добавляем возможность прокидывать ссылку в TabsItem

@SevereCloud SevereCloud requested a review from a team as a code owner January 23, 2024 11:01
Copy link
Contributor

size-limit report 📦

Path Size
JS 348.02 KB (0%)
JS (gzip) 106.44 KB (0%)
JS (brotli) 87.96 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 256.57 KB (+0.01% 🔺)
CSS (gzip) 33.62 KB (+0.02% 🔺)
CSS (brotli) 27.3 KB (-0.02% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa6bd7c:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit aa6bd7c

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dd1fcb) 81.36% compared to head (aa6bd7c) 81.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6439   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         327      327           
  Lines       10141    10141           
  Branches     3413     3413           
=======================================
  Hits         8251     8251           
  Misses       1890     1890           
Flag Coverage Δ
unittests 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit 18ee39c into master Jan 25, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue5879 branch January 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][TabsItem]: Поддержать href проп
3 participants