Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IconButton): add fit-content #6440

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(IconButton): add fit-content #6440

merged 1 commit into from
Jan 24, 2024

Conversation

SevereCloud
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

IconButton с href мог растягиваться на всю ширину контейнера

Изменения

Добавлен fit-content

@SevereCloud SevereCloud requested a review from a team as a code owner January 23, 2024 11:50
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 23, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 348.02 KB (0%)
JS (gzip) 106.44 KB (0%)
JS (brotli) 87.96 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 256.61 KB (+0.03% 🔺)
CSS (gzip) 33.64 KB (+0.06% 🔺)
CSS (brotli) 27.3 KB (+0.02% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51fc2f9:

Sandbox Source
VKUI TypeScript Configuration
quirky-newton-j54wm4 Issue #6057

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dd1fcb) 81.36% compared to head (51fc2f9) 81.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6440   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         327      327           
  Lines       10141    10141           
  Branches     3413     3413           
=======================================
  Hits         8251     8251           
  Misses       1890     1890           
Flag Coverage Δ
unittests 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit 51fc2f9

@SevereCloud SevereCloud merged commit fdab21d into master Jan 24, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6057 branch January 24, 2024 10:06
vkcom-publisher pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][IconButton]: Растягивается компонент в режиме ссылки
3 participants