fix(Search): edit after transition #7487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit b62be99 |
inomdzhon
removed
the
patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7487 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 384 384
Lines 11225 11226 +1
Branches 3682 3683 +1
=======================================
+ Hits 10684 10685 +1
Misses 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
reviewed
Sep 2, 2024
- обернул кнопку под `after` в отдельный `<div>`; - удалил анимацию `margin-inline` путём выставления отступов через `::before` и `::after` у нового `<div>`; - у `::after` минусуем отступ справа, который выставляется у `Search` если он есть (завязываемся на `.Search--withPadding`); - удаляем `Search__afterText`, т.к. у `Button` уже есть логика обрезания текста (⚠️ правда через `ellipsis`, а не `clip`); - обновили скриншоты, т.к. привели отступы к соответствие с дизайном. Дополнительно: - для ясности точечно применяем `flex-grow` и `flex-basis` вместо шортката `flex`; - в условие проверки на выставление `styles['Search--has-after']` добавляем `platform === 'ios'`; - выносом проверку `platform === 'ios' && after` в переменную.
inomdzhon
force-pushed
the
imirdzhamolov/issue7460/fix/Search-cancel-button
branch
from
02a9824
to
b62be99
Compare
Вернул обёртку 🥲 ⚡ b62be99 |
andrey-medvedev-vk
approved these changes
Sep 4, 2024
inomdzhon
deleted the
imirdzhamolov/issue7460/fix/Search-cancel-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
обернул кнопку под
afterв отдельный<div>;удалил анимацию
margin-inlineпутём выставления отступов через::beforeи::afterу нового<div>;у
::afterминусуем отступ справа, который выставляется уSearchесли он есть (завязываемся на.Search--withPadding);удалил⚠️ правда через см. fix(Search): edit after transition #7487 (comment)Search__afterText, т.к. уButtonуже есть логика обрезания текста (ellipsis, а неclip);у кнопки выставил
hoverModeиactiveModeна"opacity";обновил скриншоты, т.к. привёл отступы к соответствие с дизайном.
У кнопки слева/справа 12px, а вокруг обёртки над кнопкой по 4px (справа отступ минусуем, см. п.3)
Изменения
flex-growиflex-basisвместо шорткатаflex;styles['Search--has-after']добавляемplatform === 'ios';platform === 'ios' && afterв переменную.Release notes
Исправления