Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ToolButton): apply design fixes #7488

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Aug 30, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

см. #7359

Release notes

Улучшения

  • ToolButton: при direction="row" теперь:
    • применяется режим rounded что с передачей children, что без;
    • прибивается по левому краю;
    • имеет больший отступ справа при передаче children, чтобы скомпенсировать иконку

@inomdzhon inomdzhon requested a review from a team as a code owner August 30, 2024 13:28
Copy link
Contributor

github-actions bot commented Aug 30, 2024

size-limit report 📦

Path Size
JS 382.46 KB (+0.04% 🔺)
JS (gzip) 115.8 KB (+0.04% 🔺)
JS (brotli) 95.09 KB (+0.22% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.43 KB (+0.07% 🔺)
CSS (gzip) 39.72 KB (+0.13% 🔺)
CSS (brotli) 31.87 KB (-0.04% 🔽)

Copy link

codesandbox-ci bot commented Aug 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@inomdzhon inomdzhon marked this pull request as draft August 30, 2024 13:32
Copy link
Contributor

github-actions bot commented Aug 30, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (5a54362) to head (9e669ee).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7488   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         384      384           
  Lines       11267    11275    +8     
  Branches     3693     3697    +4     
=======================================
+ Hits        10721    10729    +8     
  Misses        546      546           
Flag Coverage Δ
unittests 95.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

👀 Docs deployed

Commit 9e669ee

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 7, 2024
@inomdzhon inomdzhon force-pushed the imirdzhamolov/issue7359/feat/ToolButton-design-fix branch from 3cfbad6 to a5cf362 Compare September 11, 2024 09:20
@inomdzhon inomdzhon marked this pull request as ready for review September 11, 2024 09:32
@inomdzhon inomdzhon force-pushed the imirdzhamolov/issue7359/feat/ToolButton-design-fix branch from a5cf362 to 9e669ee Compare September 11, 2024 09:32
@inomdzhon inomdzhon removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 11, 2024
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

идеально очень хорошо очень здорово

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@inomdzhon inomdzhon merged commit 722abe1 into master Sep 11, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue7359/feat/ToolButton-design-fix branch September 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][ToolButton]: Rounded режим для горизонтальной ToolButton + фиксы
5 participants