Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): Add compact tokens for font-weight and font-family #7564

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

andrey-medvedev-vk
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk commented Sep 11, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Добавили токены fontWeight и fontFamily для compact режима, плюс фолббэк на regular токены.

Release notes

Улучшения

  • Text: добавлено использование compact токенов fontWeight/fontFamily в режиме compact

Copy link
Contributor

github-actions bot commented Sep 11, 2024

size-limit report 📦

Path Size
JS 382.31 KB (0%)
JS (gzip) 115.76 KB (0%)
JS (brotli) 94.89 KB (0%)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.87 KB (+0.21% 🔺)
CSS (gzip) 39.74 KB (+0.2% 🔺)
CSS (brotli) 31.92 KB (+0.13% 🔺)

Copy link
Contributor

github-actions bot commented Sep 11, 2024

👀 Docs deployed

Commit 4c188fe

Copy link

codesandbox-ci bot commented Sep 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (ad82c81) to head (4c188fe).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7564   +/-   ##
=======================================
  Coverage   95.14%   95.15%           
=======================================
  Files         384      384           
  Lines       11224    11267   +43     
  Branches     3686     3693    +7     
=======================================
+ Hits        10679    10721   +42     
- Misses        545      546    +1     
Flag Coverage Δ
unittests 95.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

e2e tests

Playwright Report

@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review September 11, 2024 10:20
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner September 11, 2024 10:20
@andrey-medvedev-vk andrey-medvedev-vk merged commit a91873b into master Sep 11, 2024
28 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the mendrew/Text/adaptivity branch September 11, 2024 12:57
@vkcom-publisher
Copy link
Contributor

v6.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants