Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech: Apply no-useless-computed-key eslint rule #7571

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

andrey-medvedev-vk
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk commented Sep 11, 2024

Описание

Добавляем в eslint правило no-useless-computed-key

Основано на #7555 (comment)

Release notes

Исправления

  • Вычисляемые свойства в объектах приведены к обычным там, где они были ненужны

Copy link
Contributor

github-actions bot commented Sep 11, 2024

size-limit report 📦

Path Size
JS 383.61 KB (0%)
JS (gzip) 116.03 KB (0%)
JS (brotli) 95.29 KB (0%)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.43 KB (0%)
CSS (gzip) 41.3 KB (0%)
CSS (brotli) 32.74 KB (0%)

Copy link

codesandbox-ci bot commented Sep 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 11, 2024

👀 Docs deployed

Commit b1e2bee

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (722abe1) to head (b1e2bee).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7571   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         384      384           
  Lines       11304    11304           
  Branches     3712     3712           
=======================================
  Hits        10758    10758           
  Misses        546      546           
Flag Coverage Δ
unittests 95.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk andrey-medvedev-vk self-assigned this Sep 11, 2024
@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review September 11, 2024 13:42
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner September 11, 2024 13:42
@inomdzhon inomdzhon added this to the v6.7.0 milestone Sep 11, 2024
@andrey-medvedev-vk andrey-medvedev-vk merged commit f80081c into master Sep 11, 2024
53 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the mendrew/add-no-useless-computed-key branch September 11, 2024 15:50
@vkcom-publisher
Copy link
Contributor

v6.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants