Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalCell): rename prop header to title #7698

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 2, 2024


  • e2e-тесты
  • Release notes
  • Codemod

Описание

Переименовать свойство header на title в компоненте HorizontalCell

Release notes

BREAKING CHANGE

  • HorizontalCell: свойство header переименовано на title

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 2, 2024 08:56
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size
JS 385.7 KB (-0.01% 🔽)
JS (gzip) 116.73 KB (+0.01% 🔺)
JS (brotli) 95.94 KB (+0.22% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.74 KB (0%)
CSS (gzip) 41.58 KB (0%)
CSS (brotli) 32.95 KB (0%)

Copy link

codesandbox-ci bot commented Oct 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 2, 2024

👀 Docs deployed

Commit 7a6bdf5

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (ccb6246) to head (7a6bdf5).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7698      +/-   ##
==========================================
+ Coverage   95.14%   95.75%   +0.61%     
==========================================
  Files         383      383              
  Lines       11343    15140    +3797     
  Branches     3718     5681    +1963     
==========================================
+ Hits        10792    14498    +3706     
- Misses        551      642      +91     
Flag Coverage Δ
unittests 95.75% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft October 2, 2024 10:20
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review October 7, 2024 12:22
@EldarMuhamethanov EldarMuhamethanov merged commit 58a1ecd into master Oct 11, 2024
53 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7697/rename-prop-header-to-title branch October 11, 2024 11:46
@BlackySoul BlackySoul mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] HorizontalCell: переименовать свойство header -> title
3 participants