-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests ids props for Calendar, CalendarRange, DateInputRange, DateInput #7705
feat: add tests ids props for Calendar, CalendarRange, DateInputRange, DateInput #7705
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit c36d960 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7705 +/- ##
=======================================
Coverage 95.37% 95.38%
=======================================
Files 378 378
Lines 11160 11169 +9
Branches 3711 3720 +9
=======================================
+ Hits 10644 10653 +9
Misses 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Класс 👏 👏 👏
Поправишь, пожалуйста, конфликты?
…dars # Conflicts: # packages/vkui/src/components/CalendarDay/CalendarDay.test.tsx # packages/vkui/src/components/CalendarRange/CalendarRange.test.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
…dars # Conflicts: # packages/vkui/src/components/CalendarTime/CalendarTime.tsx # packages/vkui/src/components/DateInput/DateInput.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сможем в v6 закинуть?
Возможно не особо имеет смысл в v6 засовывать, так как это не баг. Плюс придется конфликты неприятные разруливать |
Да, не баг, но мы сейчас и минорные изменения в последние патчи v6 кидаем. 🙈 |
В целом да, можно и в v6 зарелизить👍 |
PS: добавил лейбл |
❌ PatchНе удалось автоматически применить исправление на ветке v6.
Чтобы изменение попало в ветку v6, выполните следующие действия:
git stash # опционально
git fetch origin v6
git checkout -b patch/pr7705 origin/v6
git cherry-pick --no-commit 12e1d2b4cddbafc8dfe8883e3b38ea8869c4f193
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr7705
gh pr create --base v6 --title "patch: pr7705" --body "- patch #7705" |
Описание
Нужно добавить прокидывание тестовых айдишников для важных для тестирования элементов. Это нужно сделать для компонентов
CalendarDay
,CalendarDays
,Calendar
,CalendarHeader
,CalendarRange
,DateInput
,DateRangeInput
Изменения
Calendar
иCalendarRange
Release notes
Улучшения
data-testid
у вложенных элементовdata-testid
у вложенных элементовdata-testid
у вложенных элементовdata-testid
у вложенных элементов