Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichCell): rename props header, text, caption #7719

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • codemod

Описание

Необходимо переименовать свойство text в subtitle, caption в extraSubtitle, subhead в overTitle компонента RichCell

Release notes

BREAKING CHANGE

  • RichCell:
    • Переименовано свойство text на subtitle
    • Переименовано свойство caption на extraSubtitle
    • Переименовано свойство subhead на overTitle

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 7, 2024 15:08
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
JS 385.76 KB (+0.01% 🔺)
JS (gzip) 116.74 KB (+0.01% 🔺)
JS (brotli) 95.88 KB (-0.06% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.78 KB (+0.02% 🔺)
CSS (gzip) 41.58 KB (+0.01% 🔺)
CSS (brotli) 32.94 KB (-0.05% 🔽)

Copy link

codesandbox-ci bot commented Oct 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 7, 2024

👀 Docs deployed

Commit 37576e1

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (6d9899e) to head (37576e1).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7719   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         383      383           
  Lines       11343    11343           
  Branches     3718     3718           
=======================================
  Hits        10792    10792           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon previously approved these changes Oct 8, 2024
@EldarMuhamethanov EldarMuhamethanov merged commit b1c4ac5 into master Oct 11, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7716/rich-cell-props-renaming branch October 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants