-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] feat: rename appearance to colorScheme #7728
[BREAKING CHANGE] feat: rename appearance to colorScheme #7728
Conversation
… to useAutoDetectColorScheme
…me, ColorSchemeType
…rops to ColorSchemeProvider, ColorSchemeTypeProps
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 83433d2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7728 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 383 383
Lines 11343 11343
Branches 3718 3718
=======================================
Hits 10792 10792
Misses 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Крут 🔥
Отметил пару моментов, которые заметил
revert renaming Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
…rance-to-color-scheme' into e.muhamethanov/7717/rename-appearance-to-color-scheme
Надо здесь тоже поменять |
Точно, все такие пропустил |
appearance
, который отвечает за'light'
/'dark'
, вcolorScheme
#7717Описание
Сейчас
appearance
обозначает цветовую схему приложения'dark' | 'light'
, а также используется в компонентах как цветовое оформление компонента. Нужно переименовать упоминанияappearance
наcolorScheme
Изменения
Appearance
переименована вColorScheme
. Реализован кодмодAppearanceType
переименован вColorSchemeType
. Реализован кодмодAppearanceProvider
переименован вColorSchemeProvider
,AppearanceProviderProps
переименован вColorSchemeProviderProps
. Реализован кодмодuseAppearance
переименован вuseColorScheme
. Реализован кодмодConfigProvider
иConfigProviderProps
свойствоappearance
переименовано вcolorScheme
ConfigProviderContext
свойствоappearance
переименовано вcolorScheme
appearance
наcolorScheme
Release notes
BREAKING CHANGE
Appearance
переименована вColorScheme
AppearanceType
переименован вColorSchemeType
AppearanceProvider
переименован вColorSchemeProvider
,AppearanceProviderProps
переименован вColorSchemeProviderProps
useAppearance
переименован вuseColorScheme
ConfigProvider
иConfigProviderProps
свойствоappearance
переименовано вcolorScheme
ConfigProviderContext
свойствоappearance
переименовано вcolorScheme