Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): change color of neutral primary button #7802

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 21, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Release notes
  • Codemod

Описание

Обновил версию vkui-tokens.
Для компонента Button в состоянии mode="primary" и appearance="neutral" изменен цвет

Release notes

BREAKING CHANGE

  • Button: Изменен цвет компонента в состоянии mode="primary" и appearance="neutral"
    Switch M3 Dark (4)

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 21, 2024 08:15
Copy link

codesandbox-ci bot commented Oct 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

size-limit report 📦

Path Size
JS 380.52 KB (0%)
JS (gzip) 115.34 KB (0%)
JS (brotli) 94.99 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.08 KB (+0.05% 🔺)
CSS (gzip) 42.08 KB (+0.07% 🔺)
CSS (brotli) 33.22 KB (+0.19% 🔺)

Copy link
Contributor

github-actions bot commented Oct 21, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 21, 2024

👀 Docs deployed

Commit 2df1635

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (43a6605) to head (2df1635).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7802   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         376      376           
  Lines       11074    11074           
  Branches     3677     3677           
=======================================
  Hits        10530    10530           
  Misses        544      544           
Flag Coverage Δ
unittests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft October 21, 2024 08:45
…y-neutral

# Conflicts:
#	packages/vkui/src/components/Button/__image_snapshots__/button-counter-vkcom-chromium-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-counter-vkcom-firefox-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-counter-vkcom-webkit-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-chromium-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-chromium-light-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-firefox-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-firefox-light-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-webkit-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-state-vkcom-webkit-light-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-vkcom-chromium-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-vkcom-firefox-dark-1-snap.png
#	packages/vkui/src/components/Button/__image_snapshots__/button-vkcom-webkit-dark-1-snap.png
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review October 22, 2024 11:54
@inomdzhon inomdzhon merged commit 80cae47 into master Oct 24, 2024
28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/7775/redesign-button-primary-neutral branch October 24, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Button]: Чёрная кнопка в режиме Appearance = Neutral, Mode = Primary
4 participants