Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usePatchChildren): add reexport #7812

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Oct 22, 2024


  • Unit-тесты
  • Release notes

Описание

Добавил тестов для покрытия 100%.

Release notes

Улучшения

  • Добавлен экспорт usePatchChildren() – хук позволяет пропатчить переданный компонент так, чтобы можно было получить ссылку на его DOM-элемент. Также есть возможность прокинуть в компонент дополнительные параметры.

@inomdzhon inomdzhon added this to the v7.0.0-beta.1 milestone Oct 22, 2024
@inomdzhon inomdzhon self-assigned this Oct 22, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner October 22, 2024 14:51
Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size
JS 380.8 KB (+0.01% 🔺)
JS (gzip) 115.46 KB (+0.02% 🔺)
JS (brotli) 94.99 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.15 KB (0%)
CSS (gzip) 42.09 KB (0%)
CSS (brotli) 33.18 KB (0%)

Copy link

codesandbox-ci bot commented Oct 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 22, 2024

👀 Docs deployed

Commit 8baaeac

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (74715c7) to head (8baaeac).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7812      +/-   ##
==========================================
+ Coverage   95.12%   95.14%   +0.01%     
==========================================
  Files         376      376              
  Lines       11086    11087       +1     
  Branches     3682     3682              
==========================================
+ Hits        10546    10549       +3     
+ Misses        540      538       -2     
Flag Coverage Δ
unittests 95.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- удалил `useEffectDev` в пользу ошибки от **React**, если у кастомного компонента нет getRootRef;
- добавил тестов для покрытия 100%
@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.1, v7.0.0 Oct 23, 2024
@inomdzhon inomdzhon merged commit f2ddd2a into master Oct 23, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/reexport-usePatchChildren branch October 23, 2024 13:16
@inomdzhon inomdzhon modified the milestones: v7.0.0, v7.0.0-beta.1 Oct 23, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants