Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useCounter): add docs and tests #7828

Merged

Conversation

SevereCloud
Copy link
Contributor

Описание

API useCounter не похоже на useState

Изменения

  • Делаем возврат функции useCounter похожим на useState
  • Добавляем документацию
  • Добавляем тестов

Release notes

- Делаем возврат функции useCounter похожим на useState
- Добавляем документацию
- Добавляем тестов
@SevereCloud SevereCloud requested a review from a team as a code owner October 24, 2024 10:33
Copy link
Contributor

size-limit report 📦

Path Size
JS 381.03 KB (-0.01% 🔽)
JS (gzip) 115.48 KB (0%)
JS (brotli) 95.09 KB (-0.06% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.17 KB (0%)
CSS (gzip) 42.1 KB (0%)
CSS (brotli) 33.16 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 0ac0998

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (ecdd31a) to head (0ac0998).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7828   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         377      377           
  Lines       11090    11092    +2     
  Branches     3685     3687    +2     
=======================================
+ Hits        10552    10554    +2     
  Misses        538      538           
Flag Coverage Δ
unittests 95.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit 9c0f507 into master Oct 24, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/refactor/useCounter/add-docs-and-tests branch October 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants