Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): loading is disabled #7830

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(Button): loading is disabled #7830

merged 1 commit into from
Oct 28, 2024

Conversation

SevereCloud
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Кнопка со свойством loading была кликабельна

Изменения

Кнопка при loading теперь имеет атрибут disabled

Release notes

Исправления

  • Button: кнопка со свойством loading была кликабельна

@SevereCloud SevereCloud requested a review from a team as a code owner October 24, 2024 12:14
Copy link
Contributor

size-limit report 📦

Path Size
JS 381.06 KB (+0.02% 🔺)
JS (gzip) 115.47 KB (+0.02% 🔺)
JS (brotli) 95.01 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.31 KB (+0.03% 🔺)
CSS (gzip) 42.13 KB (+0.03% 🔺)
CSS (brotli) 33.18 KB (-0.06% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit d177276

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (ecdd31a) to head (d177276).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7830   +/-   ##
=======================================
  Coverage   95.14%   95.15%           
=======================================
  Files         377      377           
  Lines       11090    11094    +4     
  Branches     3685     3689    +4     
=======================================
+ Hits        10552    10556    +4     
  Misses        538      538           
Flag Coverage Δ
unittests 95.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit 80116e3 into master Oct 28, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue7663 branch October 28, 2024 10:16
@inomdzhon
Copy link
Contributor

Фикс нужно в v6.7.4 патчить?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Button в состоянии загрузки кликабелен
4 participants