Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CalendarTime): fix picker width #7831

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


Описание

После рефакторинга CustomScrollView на нативный скроллбар текст в пикере времени в Calendar перестал вмещаться в одну строку в выбранном состоянии
image
Произошло это из-за того, что теперь скроллбар занимает место и сдвигает контент
Поэтому нужно увеличить ширину пикера, чтобы текст вмещался

Release notes

Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size
JS 381 KB (0%)
JS (gzip) 115.45 KB (0%)
JS (brotli) 95.03 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.24 KB (0%)
CSS (gzip) 42.12 KB (0%)
CSS (brotli) 33.21 KB (+0.05% 🔺)

Copy link

codesandbox-ci bot commented Oct 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (9c0f507) to head (185a763).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7831   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         377      377           
  Lines       11092    11092           
  Branches     3687     3687           
=======================================
  Hits        10554    10554           
  Misses        538      538           
Flag Coverage Δ
unittests 95.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit 185a763

@EldarMuhamethanov EldarMuhamethanov merged commit 97b90eb into master Oct 25, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-calendar-picker-width branch October 25, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants