Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove or edit TODO [>=7] #7832

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

Описание

Нужно убрать устаревшие TODO >=7 или поменять их на >=8

Изменения

  • В компоненте ContentBadge убрал TODO [>=7]: переименовать в Badge, в компоненте Badge убрал TODO [>=7]: переименовать в Dot (см. ссылка на обсуждение)
  • В postcss.js поменял TODO [>=7] на TODO [>=8] так как в v7 gap так и не поддерживается всем браузерами
  • В platform.ts поменял TODO [>=7] на TODO [>=8] , так как пока не договорились об именовании

Release notes

@EldarMuhamethanov EldarMuhamethanov added this to the v7.0.0-beta.2 milestone Oct 24, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Oct 24, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 24, 2024 12:51
Copy link
Contributor

size-limit report 📦

Path Size
JS 381 KB (0%)
JS (gzip) 115.45 KB (0%)
JS (brotli) 95.03 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.24 KB (0%)
CSS (gzip) 42.12 KB (0%)
CSS (brotli) 33.2 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (9c0f507) to head (b61a904).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7832   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         377      377           
  Lines       11092    11092           
  Branches     3687     3687           
=======================================
  Hits        10554    10554           
  Misses        538      538           
Flag Coverage Δ
unittests 95.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit b61a904

@inomdzhon inomdzhon removed this from the v7.0.0-beta.2 milestone Oct 24, 2024
@inomdzhon inomdzhon merged commit e6ce861 into master Oct 24, 2024
28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/remove-old-todo branch October 24, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants