-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] feat(FormItem): remove topNode #7837
[BREAKING CHANGE] feat(FormItem): remove topNode #7837
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 3b831b0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7837 +/- ##
==========================================
+ Coverage 95.14% 95.16% +0.01%
==========================================
Files 377 377
Lines 11092 11092
Branches 3687 3687
==========================================
+ Hits 10554 10556 +2
+ Misses 538 536 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Описание
Нужно в компоненте
FormItem
избавиться от свойстваtopNode
и заменить наtop
.Изменения
Для сохранения совместимости теперь при прокидывании в top ReactElement она рендерится без оборачивания в другие компоненты, а при прокидывании строки, оборачивается в FormItemLabel
Release notes
BREAKING CHANGE
FormItem: удалено свойство
topNode
, вместо него можно использовать свойствоtop
Пример миграции