Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] feat(FormItem): remove topNode #7837

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • Release notes
  • Codemod

Описание

Нужно в компоненте FormItem избавиться от свойства topNode и заменить на top.

Изменения

Для сохранения совместимости теперь при прокидывании в top ReactElement она рендерится без оборачивания в другие компоненты, а при прокидывании строки, оборачивается в FormItemLabel

Release notes

BREAKING CHANGE

  • FormItem: удалено свойство topNode, вместо него можно использовать свойство top

    Пример миграции
    <FormItem
    - topNode={
    + top={
        <FormItem.Top>
          <FormItem.TopLabel htmlFor="about">Дополнительная информация</FormItem.TopLabel>
          <FormItem.TopAside>0/100</FormItem.TopAside>
        </FormItem.Top>
      }
    >
      <Textarea id="about" name="about" />
    </FormItem>

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 380.98 KB (-0.01% 🔽)
JS (gzip) 115.45 KB (-0.01% 🔽)
JS (brotli) 95.05 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.24 KB (0%)
CSS (gzip) 42.12 KB (0%)
CSS (brotli) 33.2 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 3b831b0

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (e6ce861) to head (3b831b0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7837      +/-   ##
==========================================
+ Coverage   95.14%   95.16%   +0.01%     
==========================================
  Files         377      377              
  Lines       11092    11092              
  Branches     3687     3687              
==========================================
+ Hits        10554    10556       +2     
+ Misses        538      536       -2     
Flag Coverage Δ
unittests 95.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 018c92d into master Oct 25, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/form-item-remove-topNode branch October 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants