Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CustomSelectInput): wrong classname #7856

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

BlackySoul
Copy link
Contributor

Описание

Из-за особенностей генерации css-классов generate_scoped_name: 'vkui[folder]_[local]', мы можем наткнуться на дубликаты классов, если файлы *.modules.css лежат в одной папке.

Release notes

@BlackySoul BlackySoul requested a review from a team as a code owner October 28, 2024 08:14
Copy link
Contributor

size-limit report 📦

Path Size
JS 381.05 KB (+0.02% 🔺)
JS (gzip) 115.46 KB (+0.01% 🔺)
JS (brotli) 95.04 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.45 KB (+0.07% 🔺)
CSS (gzip) 42.15 KB (+0.08% 🔺)
CSS (brotli) 33.19 KB (-0.08% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 673dbec

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (e92e114) to head (673dbec).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7856   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         377      377           
  Lines       11092    11092           
  Branches     3687     3687           
=======================================
  Hits        10556    10556           
  Misses        536      536           
Flag Coverage Δ
unittests 95.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul self-assigned this Oct 28, 2024
@BlackySoul BlackySoul added this to the v7.0.0-beta.2 milestone Oct 28, 2024
@BlackySoul BlackySoul merged commit e6f8e34 into master Oct 28, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_CustomSelectInput branch October 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants