Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Header): rm mode prop and increase size values #7863

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat(Header): rm mode prop and increase size values #7863

merged 2 commits into from
Oct 30, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 29, 2024 •
edited
Loading

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Release notes
  • Codemod

Описание

Необходимо привести компонент Header к новому дизайну. А именно избавиться от свойства mode и увеличить количество значений свойства size: добавить 's' и 'xl'

Изменения

  • Удалил свойство mode
  • Добавил к свойству size значения s и xl
  • Поправил стили по новому дизайну
  • Добавил кодмод с логикой удаления mode
  • Обновил скриншоты

Release notes

Улучшения

  • Header: добавлены значения для свойства size: 's' и 'xl'

BREAKING CHANGE

  • Header: свойство mode было удалено. Логика удаления свойства mode:
    size="l" mode="primary" заменяется на size="xl"
    size="m" mode="primary" заменяется на size="m"
    mode="tertiary" заменяется на size="m"
    mode="secondary" заменяется на size="s"

@EldarMuhamethanov EldarMuhamethanov added this to the v7.0.0-beta.2 milestone Oct 29, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Oct 29, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 29, 2024 08:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 378.14 KB (-0.07% 🔽)
JS (gzip) 114.62 KB (-0.02% 🔽)
JS (brotli) 94.34 KB (-0.07% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.4 KB (+0.07% 🔺)
CSS (gzip) 42.11 KB (-0.04% 🔽)
CSS (brotli) 33.16 KB (-0.28% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 29, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

👀 Docs deployed

Commit 1518ddc

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (e92e114) to head (1518ddc).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7863      +/-   ##
==========================================
- Coverage   95.16%   95.16%   -0.01%     
==========================================
  Files         377      375       -2     
  Lines       11092    10980     -112     
  Branches     3687     3641      -46     
==========================================
- Hits        10556    10449     -107     
+ Misses        536      531       -5
Flag Coverage Δ
unittests 95.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qurle
qurle approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде всё круто.

Понимаю, что можем растерять некоторые состояние типа серого некапсового текста, но зато чуть систематизируем существующее.

Вкком использует Display Title в двух из трёх своих состояний Adopted компонента. Может, есть смысл добавить для них проп, который переключает шрифт на акцентный?

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🥇

@EldarMuhamethanov EldarMuhamethanov merged commit 50960ea into master Oct 30, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/header-improve-sizes branch October 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@qurle qurle qurle approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
breaking-change cmp:header
Projects
VKUI
Archived in project
Milestone
v7.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
4 participants
@EldarMuhamethanov @inomdzhon @qurle @andrey-medvedev-vk