Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateInput): use zero values with keyboard input #7872

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

BlackySoul
Copy link
Contributor

  • Unit-тесты
  • Release notes

Описание

При ручном вводе даты (со временем и без), необходимо занулять секунды/миллисекунды (с часами и минутами, если дата без времени).

Release notes

Исправления

  • DateInput: инициализируем секунды и миллисекунды (часы и минуты при вводе без времени) нулевыми значениями при ручном вводе даты

@BlackySoul BlackySoul requested a review from a team as a code owner October 29, 2024 14:41
@BlackySoul BlackySoul self-assigned this Oct 29, 2024
@BlackySoul BlackySoul added cmp:date-input v6 Автоматизация: PR продублируется в ветку v6 patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Oct 29, 2024
@BlackySoul BlackySoul added this to the v7.0.0-beta.2 milestone Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size
JS 383.13 KB (+0.03% 🔺)
JS (gzip) 122.56 KB (+0.02% 🔺)
JS (brotli) 101.52 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link

codesandbox-ci bot commented Oct 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 3e69bfc

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (e44a13f) to head (7f7aa49).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7872      +/-   ##
==========================================
+ Coverage   95.17%   95.35%   +0.18%     
==========================================
  Files         376      376              
  Lines       11030    10947      -83     
  Branches     3669     3640      -29     
==========================================
- Hits        10498    10439      -59     
+ Misses        532      508      -24     
Flag Coverage Δ
unittests 95.35% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v6.7.4 Nov 5, 2024
@BlackySoul BlackySoul removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 7, 2024
@BlackySoul BlackySoul merged commit ad3b299 into master Nov 7, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_dateinput_seconds branch November 7, 2024 12:35
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке v6.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку v6, выполните следующие действия:

  1. Создайте новую ветку от v6 и примените изменения используя cherry-pick
git stash # опционально
git fetch origin v6
git checkout -b patch/pr7872 origin/v6

git cherry-pick --no-commit ad3b29962edae5dc5eb0f9baa67bac46241cc756
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой v6 (установка лейбла не требуется!)
git push --set-upstream origin patch/pr7872
gh pr create --base v6 --title "patch: pr7872" --body "- patch #7872"

BlackySoul added a commit that referenced this pull request Nov 7, 2024
* fix(DateInput): use zero values with keyboard input

* fix: use date-fns functions
@BlackySoul BlackySoul mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:date-input v6 Автоматизация: PR продублируется в ветку v6
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants