Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: pr7877 #7905

Merged
merged 1 commit into from
Nov 6, 2024
Merged

patch: pr7877 #7905

merged 1 commit into from
Nov 6, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

* fix(Galery): fix autoPlay when dragging slides

* fix(HorizontalScroll): remove unused useEffect

* fix(Gallery): rm useImperativeHandler and return controls from hook

* fix(Gallery): rm import

* fix(useAutoPlay): use useCallback

* fix(useAutoPlay): rm import

(cherry picked from commit 3661e98)
@EldarMuhamethanov EldarMuhamethanov self-assigned this Nov 6, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 6, 2024 11:39
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 6, 2024
@EldarMuhamethanov EldarMuhamethanov changed the title fix(Galery): fix autoPlay when dragging slides (#7877) patch: pr7877 Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size
JS 385.33 KB (+0.09% 🔺)
JS (gzip) 116.5 KB (+0.1% 🔺)
JS (brotli) 95.63 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 331.11 KB (0%)
CSS (gzip) 41.34 KB (0%)
CSS (brotli) 32.7 KB (0%)

Copy link

codesandbox-ci bot commented Nov 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 6, 2024

👀 Docs deployed

Commit c12af02

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.18%. Comparing base (af6aa97) to head (c12af02).
Report is 2 commits behind head on 6.7-stable.

Files with missing lines Patch % Lines
packages/vkui/src/components/Gallery/hooks.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           6.7-stable    #7905      +/-   ##
==============================================
- Coverage       95.18%   95.18%   -0.01%     
==============================================
  Files             383      383              
  Lines           11344    11349       +5     
  Branches         3732     3733       +1     
==============================================
+ Hits            10798    10802       +4     
- Misses            546      547       +1     
Flag Coverage Δ
unittests 95.18% <96.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 72d104a into 6.7-stable Nov 6, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the patch/pr7877 branch November 6, 2024 13:01
@VKCOM VKCOM deleted a comment from vkcom-publisher Nov 7, 2024
@inomdzhon inomdzhon removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants