add effective user context manipulation routines #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrShumilov
added
enhancement
PetrShumilov
force-pushed
the
pshumilov/remove_rt_sigprocmask
branch
25 times, most recently
from
a130fb4
to
868512e
Compare
PetrShumilov
force-pushed
the
pshumilov/remove_rt_sigprocmask
branch
from
868512e
to
8af5e3f
Compare
PetrShumilov
force-pushed
the
pshumilov/remove_rt_sigprocmask
branch
from
381fabd
to
010fd7e
Compare
astrophysik
reviewed
Oct 30, 2024
| stack_end = reinterpret_cast<char *>(get_context_stack_ptr_portable(exit_context)) + get_context_stack_size_portable(exit_context); | ||
|
|
||
| #if defined(__linux__) && defined(__x86_64__) | ||
| // The PhpScript::error may be produced in process of signal handling. The default behavior on Linux-based platforms |
There was a problem hiding this comment.
We also have own implementation for darwin aarch64. Do we need same logic for this?
There was a problem hiding this comment.
I will check it. Previously, we also had own implementation for darwin aarch64 but no needed a special handling for this case. I may be a result of different signal subsystems.
There was a problem hiding this comment.
Checked, thanks for notice, fixed for darwin aarch64
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
Signed-off-by: Petr Shumilov <[email protected]>
PetrShumilov
force-pushed
the
pshumilov/remove_rt_sigprocmask
branch
from
6afd8ee
to
9635dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
rt_sigprocmasksyscall invocation during user context manipulationRelated issues: KPHP-1944