Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch vkcom on k2 #1129

Merged
merged 16 commits into from
Nov 6, 2024
Merged

launch vkcom on k2 #1129

merged 16 commits into from
Nov 6, 2024

Conversation

astrophysik
Copy link
Contributor

@astrophysik astrophysik commented Oct 25, 2024

Description

Pr adds allows you to launch the web-site on K2

  • Add #ifndef K2 to implement the new k2 specific biltins in php code
  • Move some math functions to common
  • Add necessary functions to functions.txt
  • Fix small issues

@astrophysik astrophysik self-assigned this Oct 25, 2024
@astrophysik astrophysik added k2 k2 related runtime Feature related to runtime labels Oct 25, 2024
@astrophysik astrophysik added this to the next milestone Oct 29, 2024
@astrophysik astrophysik added the compiler Feature related to compiler label Oct 29, 2024
@astrophysik astrophysik force-pushed the vsadokhov/launch-k2-vkcom branch 3 times, most recently from ac5836f to 9f41aa2 Compare November 2, 2024 08:59
compiler/compiler.cpp Show resolved Hide resolved
@@ -103,6 +103,10 @@ void *RuntimeAllocator::realloc_script_memory(void *mem, size_t new_size, size_t

void RuntimeAllocator::free_script_memory(void *mem, size_t size) noexcept {
php_assert(size);
if (unlikely(!is_script_allocator_available())) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add it because temporary objects are created during the image creation step

@astrophysik astrophysik marked this pull request as ready for review November 2, 2024 16:24
runtime-common/stdlib/math/math-functions.h Outdated Show resolved Hide resolved
runtime-light/stdlib/rpc/rpc-api.cpp Outdated Show resolved Hide resolved
runtime-light/utils/panic.cpp Show resolved Hide resolved
apolyakov
apolyakov previously approved these changes Nov 6, 2024
compiler/compiler.cpp Show resolved Hide resolved
compiler/lexer.cpp Outdated Show resolved Hide resolved
compiler/stats.cpp Show resolved Hide resolved
compiler/stats.cpp Show resolved Hide resolved
Copy link
Contributor

@mkornaukhov03 mkornaukhov03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@astrophysik astrophysik merged commit fdd63cb into master Nov 6, 2024
5 checks passed
@astrophysik astrophysik deleted the vsadokhov/launch-k2-vkcom branch November 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Feature related to compiler k2 k2 related runtime Feature related to runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants