Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server logs refactoring #865

Merged
merged 21 commits into from
Jul 20, 2023
Merged

server logs refactoring #865

merged 21 commits into from
Jul 20, 2023

Conversation

astrophysik
Copy link
Contributor

Description

New special logging tags

This pr includes refactoring of log levels and add some more special tags

...
--verbosity-master-process[={arg}]                       	set verbosity-master-process
--verbosity-graceful-restart[={arg}]                     	set verbosity-graceful-restart
--verbosity-php-connections[={arg}]                      	set verbosity-php-connections
--verbosity-php-code[={arg}]                             	set verbosity-php-code
...
--verbosity-net-connections[={arg}]                      	set verbosity-net-connections
--verbosity-net-crypto-aes[={arg}]                       	set verbosity-net-crypto-aes

Refactor verbose level

The levels have become more deferential

-v // can be used on production server to get more logs 
-vv // also can be used on production, but it will generate many logs
-vvv // only for local debugging
-vvvv // the highest log level. It includes many deprecated and extra logs

@astrophysik astrophysik self-assigned this Jul 6, 2023
@astrophysik astrophysik added refactoring Logic and code style improvements runtime Feature related to runtime labels Jul 6, 2023
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-memcache-server.cpp Outdated Show resolved Hide resolved
net/net-memcache-server.cpp Show resolved Hide resolved
@artem
Copy link
Contributor

artem commented Jul 9, 2023

Let's sync net/ part with engines!

@astrophysik astrophysik added this to the next milestone Jul 12, 2023
server/php-runner.cpp Outdated Show resolved Hide resolved
server/php-runner.cpp Show resolved Hide resolved
server/php-runner.h Outdated Show resolved Hide resolved
server/php-worker.cpp Outdated Show resolved Hide resolved
net/net-socket.cpp Outdated Show resolved Hide resolved
server/php-master.cpp Outdated Show resolved Hide resolved
server/php-master.cpp Outdated Show resolved Hide resolved
server/php-master.cpp Outdated Show resolved Hide resolved
server/php-master.cpp Outdated Show resolved Hide resolved
server/php-worker.cpp Show resolved Hide resolved
net/net-tcp-rpc-server.cpp Outdated Show resolved Hide resolved
net/net-tcp-rpc-server.cpp Outdated Show resolved Hide resolved
net/net-tcp-rpc-server.cpp Outdated Show resolved Hide resolved
net/net-tcp-rpc-server.cpp Outdated Show resolved Hide resolved
net/net-tcp-rpc-server.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
net/net-aes-keys.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/improve-logs branch 6 times, most recently from 5f0e000 to 4bbe8a8 Compare July 19, 2023 09:21
@artem
Copy link
Contributor

artem commented Jul 19, 2023

Why did you remove error reporting in 67d247d ?

@astrophysik
Copy link
Contributor Author

Why did you remove error reporting in 67d247d ?

Return it in b745aaa

DrDet
DrDet previously approved these changes Jul 20, 2023
DrDet
DrDet previously approved these changes Jul 20, 2023
net/net-connections.cpp Show resolved Hide resolved
net/net-tcp-connections.cpp Outdated Show resolved Hide resolved
@DrDet DrDet merged commit f619c32 into master Jul 20, 2023
1 of 5 checks passed
@DrDet DrDet deleted the vsadokhov/improve-logs branch July 20, 2023 18:03
@tolk-vm tolk-vm modified the milestones: 30.06.2023, next Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Logic and code style improvements runtime Feature related to runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants