added official statshouse client, redesigned statshouse metrics #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrDet
requested changes
Jul 24, 2023
troy4eg
force-pushed
the
troy4eg/update_statshouse
branch
from
26fe919
to
84ff501
Compare
troy4eg
force-pushed
the
troy4eg/update_statshouse
branch
from
9823243
to
689a8b9
Compare
DrDet
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Let's rename all add_* methods to send_* methods to make it more clear
There was a problem hiding this comment.
all or just public? because it's a little weird to do a "send_" inside a "send_"
There was a problem hiding this comment.
Hmm.. Why? It doesn't seem weird for me
troy4eg
force-pushed
the
troy4eg/update_statshouse
branch
from
db81e7a
to
aa8a30f
Compare
troy4eg
commented
Sep 19, 2023
DrDet
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.