Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extra script time stats #891

Merged
merged 15 commits into from
Oct 16, 2023
Merged

add extra script time stats #891

merged 15 commits into from
Oct 16, 2023

Conversation

astrophysik
Copy link
Contributor

@astrophysik astrophysik commented Aug 25, 2023 •
edited
Loading

General

Add several new metrics

  • http_connection_process_time - time between http connection accepting and start of script initialization
  • script_init_time - time of script env initialization
  • script_user_time - user level time of script work
  • script_system_time - system level time of script work
  • script_voluntary_context_switches - voluntary context switches per request
  • script_involuntary_context_switches - involuntary context switches per request

@astrophysik astrophysik force-pushed the vsadokhov/connection-time-metrics branch from 28b5a50 to 9285c5e Compare August 25, 2023 14:56
@astrophysik astrophysik requested a review from DrDet August 25, 2023 15:07
@astrophysik astrophysik self-assigned this Sep 5, 2023
@astrophysik astrophysik added the enhancement New feature or request label Sep 5, 2023
DrDet
DrDet requested changes Sep 5, 2023
View reviewed changes
net/net-connections.cpp Outdated Show resolved Hide resolved
server/server-stats.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/connection-time-metrics branch from 2e6bc2b to 67e85d1 Compare September 6, 2023 14:47
@tolk-vm tolk-vm modified the milestone: next Sep 8, 2023
@astrophysik astrophysik force-pushed the vsadokhov/connection-time-metrics branch 2 times, most recently from 3df2223 to 0bc9dd3 Compare October 3, 2023 13:10
@astrophysik astrophysik added this to the next milestone Oct 10, 2023
DrDet
DrDet requested changes Oct 10, 2023
View reviewed changes
server/php-runner.h Outdated Show resolved Hide resolved
server/statshouse/worker-stats-buffer.h Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/connection-time-metrics branch from 160c163 to 3a8ce98 Compare October 11, 2023 09:05
DrDet
DrDet reviewed Oct 11, 2023
View reviewed changes
common/dl-utils-lite.h Outdated Show resolved Hide resolved
server/php-runner.h Outdated Show resolved Hide resolved
server/statshouse/statshouse-manager.cpp Outdated Show resolved Hide resolved
server/statshouse/statshouse-manager.cpp Show resolved Hide resolved
DrDet
DrDet reviewed Oct 11, 2023
View reviewed changes
server/statshouse/statshouse-manager.cpp Outdated Show resolved Hide resolved
server/statshouse/statshouse-manager.cpp Outdated Show resolved Hide resolved
DrDet
DrDet requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@DrDet DrDet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about script init time and http connection process time metrics in StatsHouse?
We must add them too

@astrophysik astrophysik merged commit 7fea206 into master Oct 16, 2023
5 checks passed
@astrophysik astrophysik deleted the vsadokhov/connection-time-metrics branch October 16, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDet DrDet DrDet approved these changes

Assignees

@astrophysik astrophysik

Labels
enhancement New feature or request
Projects
None yet
Milestone
19.10.2023
Development

Successfully merging this pull request may close these issues.
3 participants
@astrophysik @DrDet @tolk-vm