Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce PhpWorker and PhpScript heap allocations #895

Merged
merged 3 commits into from
Oct 17, 2023
Merged

reduce PhpWorker and PhpScript heap allocations #895

merged 3 commits into from
Oct 17, 2023

Conversation

astrophysik
Copy link
Contributor

@astrophysik astrophysik commented Sep 6, 2023 •
edited
Loading

change heap allocations to placement new with static align storage

Plans

  • Refactor PhpScript creation and initialization
  • Refactor init_runtime_environment

@astrophysik astrophysik added refactoring Logic and code style improvements runtime Feature related to runtime labels Sep 6, 2023
@astrophysik astrophysik self-assigned this Sep 6, 2023
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch 2 times, most recently from e59a586 to 1fab058 Compare September 8, 2023 10:34
@tolk-vm tolk-vm added this to the next milestone Sep 8, 2023
DrDet
DrDet requested changes Sep 8, 2023
View reviewed changes
runtime/interface.cpp Outdated Show resolved Hide resolved
server/php-query-data.h Outdated Show resolved Hide resolved
server/php-query-data.h Show resolved Hide resolved
server/php-query-data.cpp Outdated Show resolved Hide resolved
net/net-tcp-rpc-server.h Outdated Show resolved Hide resolved
server/php-query-data.h Outdated Show resolved Hide resolved
artem
artem suggested changes Sep 11, 2023
View reviewed changes
server/php-query-data.cpp Outdated Show resolved Hide resolved
server/php-engine.cpp Outdated Show resolved Hide resolved
server/php-engine.cpp Outdated Show resolved Hide resolved
server/php-engine.cpp Outdated Show resolved Hide resolved
server/php-worker.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch 2 times, most recently from 4d4b5dc to 808b8a2 Compare September 11, 2023 16:41
artem
artem suggested changes Sep 11, 2023
View reviewed changes
server/php-worker.cpp Outdated Show resolved Hide resolved
server/php-runner.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch 4 times, most recently from 91ff545 to f14eb94 Compare September 12, 2023 08:24
@tolk-vm tolk-vm removed this from the next milestone Sep 12, 2023
@DrDet DrDet added this to the next milestone Oct 5, 2023
DrDet
DrDet requested changes Oct 11, 2023
View reviewed changes
server/php-runner.cpp Outdated Show resolved Hide resolved
server/php-runner.cpp Outdated Show resolved Hide resolved
server/php-engine.cpp Outdated Show resolved Hide resolved
server/php-worker.cpp Outdated Show resolved Hide resolved
server/php-worker.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch 2 times, most recently from f2e9b7d to 5625173 Compare October 12, 2023 10:36
DrDet
DrDet requested changes Oct 16, 2023
View reviewed changes
runtime/interface.cpp Show resolved Hide resolved
runtime/interface.cpp Outdated Show resolved Hide resolved
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch from f43fb25 to ddbc71c Compare October 17, 2023 09:45
@astrophysik astrophysik force-pushed the vsadokhov/reduce-heap-allocations branch from ddbc71c to 87dc60d Compare October 17, 2023 09:47
@astrophysik astrophysik merged commit 29db917 into master Oct 17, 2023
5 checks passed
@astrophysik astrophysik deleted the vsadokhov/reduce-heap-allocations branch October 17, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem artem artem requested changes

@DrDet DrDet DrDet approved these changes

Assignees

@astrophysik astrophysik

Labels
refactoring Logic and code style improvements runtime Feature related to runtime
Projects
None yet
Milestone
19.10.2023
Development

Successfully merging this pull request may close these issues.
4 participants
@astrophysik @artem @DrDet @tolk-vm