Removed CurlEpollFdTracker completely #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CurlEpollFdTracker
was added as a fix of another problem but it didn't help (a37c782).Moreover it led to another crash in runtime from
free_runtime_environment
, because iterating over the array like this:kphp/runtime/curl.cpp
Line 1036 in 8a5a520
uses non-const iterator, which can mutate the array and invokes script memory allocations. In case of
memory limit exceeded
error,free_runtime_environment
is always called, which in turn calls the code described above. And it leads toSIGSEGV
in the end.