Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CurlEpollFdTracker completely #896

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

DrDet
Copy link
Contributor

@DrDet DrDet commented Sep 6, 2023

CurlEpollFdTracker was added as a fix of another problem but it didn't help (a37c782).
Moreover it led to another crash in runtime from free_runtime_environment, because iterating over the array like this:

for (auto it : used_fds_) {

uses non-const iterator, which can mutate the array and invokes script memory allocations. In case of memory limit exceeded error, free_runtime_environment is always called, which in turn calls the code described above. And it leads to SIGSEGV in the end.

@DrDet DrDet added bug Something isn't working runtime Feature related to runtime labels Sep 6, 2023
@DrDet DrDet added this to the next milestone Sep 6, 2023
@DrDet DrDet requested a review from drdzyk September 6, 2023 16:47
@DrDet DrDet self-assigned this Sep 6, 2023
@tolk-vm tolk-vm modified the milestones: 24.08.2023, next Sep 8, 2023
@DrDet DrDet merged commit cb214e2 into master Sep 8, 2023
5 checks passed
@DrDet DrDet deleted the dvaksman/remove-curl-epoll-fd-tracker branch September 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working runtime Feature related to runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants