Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tlo-parsing] Fix typo in tlo schema parser #913

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[tlo-parsing] Fix typo in tlo schema parser #913

merged 1 commit into from
Oct 9, 2023

Conversation

artem
Copy link
Contributor

@artem artem commented Oct 4, 2023 •
edited by DrDet
Loading

Due to bug tl-compiler always generates ExprNat instead of NatConst for NatExpr case.
Correct .tlo format must fit this scheme:

kphp/common/tl-files/tl.tl

Line 46 in c8dc706

tls.natConst value:int = tls.NatExpr;

Here's a fix to maintain correct .tlo format in tlo-parser.

@DrDet DrDet self-requested a review October 4, 2023 13:50
@DrDet DrDet self-assigned this Oct 9, 2023
@DrDet DrDet added the bug Something isn't working label Oct 9, 2023
@DrDet DrDet merged commit a98877f into VKCOM:master Oct 9, 2023
5 checks passed
@DrDet DrDet mentioned this pull request Oct 12, 2023
Merged
@DrDet DrDet mentioned this pull request Oct 25, 2023
Merged
@Danil42Russia Danil42Russia added this to the 19.10.2023 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDet DrDet DrDet approved these changes

Assignees

@DrDet DrDet

Labels
bug Something isn't working
Projects
None yet
Milestone
19.10.2023
Development

Successfully merging this pull request may close these issues.
3 participants
@artem @DrDet @Danil42Russia