-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linter: fixed unboxing from null for arrays #1215
Conversation
Seems quite non-obvious to me why does UnwrapArray actually panic in this case... |
@YuriyNasretdinov The problem in unwrap1 function:
if we have "null" string, then we will have slice from 5, but we have only 3 indexes. we can modify unwrap1 function to return empty string if len(s) > stringLenBytes+1, but we are talking about "types" and "null" is a special type that`s why i think we should add condition in logic of LazyArrayElemType. What do you think? |
Thanks for the explanation. I think it makes sense now. BTW I am not a maintainer of the project (but I was at some point), so I'm just being curious :). |
1eb3c84
to
6e763bf
Compare
6e763bf
to
d5db9fe
Compare
8df655a
to
6d9476b
Compare
f5b8a2e
to
99484be
Compare
No description provided.