Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code: 日本語を改善 #3

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Code: 日本語を改善 #3

merged 1 commit into from
Dec 31, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

ドキュメントの日本語をいい感じにします。

関連 Issue

（なし）

スクリーンショット・動画など

（なし）

その他

今回は自分だけでマージボタンを押してみようと思います。落ちるはず。

@sevenc-nanashi
Copy link
Member Author

強行マージしてみる

@sevenc-nanashi
Copy link
Member Author

sevenc-nanashi commented Dec 31, 2024 •
edited
Loading

落ちた！

ヒホさんが押したら通るはず？

Hiroshiba
Hiroshiba approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

無駄にapproveしてみます

@Hiroshiba
Copy link
Member

ちゃんと Total score: 1 / 2 で落ちてて良い感じ！！
この状態で @sevenc-nanashi さんがmerge開始すると通るはず？　お願いできると！！

@sevenc-nanashi sevenc-nanashi added this pull request to the merge queue Dec 31, 2024
Merged via the queue into VOICEVOX:main with commit f700415 Dec 31, 2024
2 of 3 checks passed
@Hiroshiba
Copy link
Member

お〜ちゃんとスコア3で通ってる！

Approved users:
  Hiroshiba
  sevenc-nanashi
Scores:
  Hiroshiba: 2
  sevenc-nanashi: 1
Total score: 3 / 2
Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba