Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: コード署名 #51

Merged
merged 2 commits into from
Sep 1, 2024
Merged

add: コード署名 #51

merged 2 commits into from
Sep 1, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Aug 30, 2024

内容

関連 Issue

Resolves #27.

スクリーンショット・動画など

その他

@qryxip qryxip requested a review from Hiroshiba August 30, 2024 10:30
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ!

すみません、どこにもドキュメント書いてないのですが、署名周りはenvironment機能を使っていたりします!
製品版ビルドフラグを用意して、それがtrueなら特定のenvironmentを突っ込む感じです・・・ 🙇

お手数おかけしちゃうのですが、workflow_dispatchの引数に以下を追加して、

      is_production:
        description: "製品版をビルドする"
        type: boolean
        required: false
        default: false

参考コード https://github.com/VOICEVOX/voicevox_core/blob/62bfd713557bbac412186c73a0f91ccf725080b4/.github/workflows/build_and_deploy_downloader.yml#L14-L18

あとは署名するjobの最初に↓を追加する感じをお願いします 🙇

    environment: ${{ inputs.is_production && 'production' || '' }} # コード署名用のenvironment

参考コード https://github.com/VOICEVOX/voicevox_core/blob/62bfd713557bbac412186c73a0f91ccf725080b4/.github/workflows/build_and_deploy_downloader.yml#L45

.github/workflows/shellcheck.yml Show resolved Hide resolved
@qryxip
Copy link
Member Author

qryxip commented Aug 31, 2024

#52 を考えるとinputs.name == 'voicevox_onnxruntime' && 'production' || ''という感じになるでしょうか。

あるいはENGINEのようにinputs.code_signingを用いるのはどうでしょうか?
https://github.com/VOICEVOX/voicevox_engine/blob/378b51e94da13974b59849cc47e3f9156c8bd678/.github/workflows/build-engine-package.yml#L52

@Hiroshiba
Copy link
Member

Hiroshiba commented Aug 31, 2024

あるいはENGINEのようにinputs.code_signingを用いるのはどうでしょうか?
https://github.com/VOICEVOX/voicevox_engine/blob/378b51e94da13974b59849cc47e3f9156c8bd678/.github/workflows/build-engine-package.yml#L52

あ、inputs.code_signingのが良さそう!!
すみませんがお願いできると 🙇 🙇 🙇

コア側なんでこうなってるんだろ。まあプロプライエタリ移せたらis_production消せるし、そのときにcode_signingにすると良さそう感。

@qryxip qryxip requested a review from Hiroshiba August 31, 2024 17:19
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit f58c8d1 into VOICEVOX:main Sep 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

署名する?
2 participants