twitter関連の単語ををXのものに変更 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Dec 3, 2023
There was a problem hiding this comment.
プルリクエストありがとうございます！！
Twitterでコード全体検索した感じまだ残っていそうなので、これらの変更もお願いできますか？
https://github.com/search?q=repo%3AVOICEVOX%2Fvoicevox_blog%20twitter&type=code
たぶんpage-fotter.tsx内とnemo/index.tsx内のもの？
アイコンとしてfaTwitterが使われている箇所があるのですが、これはこちらのx-twitterに変更すれば変えられると思います。
https://fontawesome.com/icons/x-twitter?f=brands&s=solid
FontAwesomeのバージョンを上げないといけないかもです。
ちなみに調べた、HTML meta部分に書かれてるtwitter:cardなどには変更がない感じでした！
https://github.com/nohimazin/voicevox_blog/blob/d5209e8822bb3b61f508b7750907d50d69197c72/src/components/seo.tsx#L77-L78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
twitter関連の単語をXのものに変更
関連 Issue
スクリーンショット・動画など
その他