Add http proxy support #110
Conversation
Many corporations require the use of a proxy server for logging etc. - We needed this so I added it. - Add a new 'proxy' option - Move from websockets to aiohttp due to no http proxy support: python-websockets/websockets#364 - Format 'proxy' option into the dictionary httpx requires for 'all://' - Updated requirements / setup.py - Updated CHANGELOG
src/mattermostdriver/websocket.py
Outdated
| self._last_msg = time.time() | ||
| await event_handler(message) | ||
| log.debug("cancelling heartbeat task") | ||
| keep_alive.cancel() | ||
| try: | ||
| await keep_alive | ||
| await websocket.close() |
There was a problem hiding this comment.
Seemed with websockets the connection was never cleanly closed. We now do so.
There was a problem hiding this comment.
Don’t do this here. The above await always raises CancelledError
Edit: move it below this try
There was a problem hiding this comment.
Also I would use the async context manager so you don’t have to explicitly close the websocket object
There was a problem hiding this comment.
I do use the context manager so probably don't need this at all ... Will remove after a maintainer reviews to save revisions.
There was a problem hiding this comment.
Kept it, as it would be nice to cleanly close the websocket then the aiohttp session that the context manager takes care of.
|
Hey @cooperlees Thanks for this! I merged this already but I am still checking it a bit with mattermost 6.3.0 which it seems somehow cant work with |
Many corporations require the use of a proxy server for logging etc. - We needed this so I added it.