Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify kernel parameters #72

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Modify kernel parameters #72

merged 3 commits into from
Aug 11, 2023

Conversation

matbme
Copy link
Member

@matbme matbme commented Jun 17, 2023

This PR adds support for modifying kernel parameters with abroot kargs edit, similarly to what was present in v1.

There is, however, some things still left to resolve:

  • For some reason, /etc/abroot/kargs and /etc/abroot/kargs.bak don't get synced if they already exist in the future root, maybe something related to the syncEtc() method.
  • ABroot runs a transaction immediately after changing kargs, it's probably a good idea to prompt the user if they want to commit changes now or later (in case they still want to add/remove packages)
  • ABroot runs the transaction regardless of whether the user actually changed any kernel parameters or even saved the file. This should be changed.

For now, I'm marking this as a draft.

@matbme matbme marked this pull request as draft June 17, 2023 14:28
@mirkobrombin
Copy link
Member

What's the status on this?

@matbme
Copy link
Member Author

matbme commented Jul 12, 2023

I couldn't figure out why /etc/abroot/kargs doesn't sync with the rest of the system. Hopefully integrating EtcBuilder into ABRoot will fix the issue and we can merge this.

@matbme matbme self-assigned this Aug 8, 2023
@matbme matbme added the enhancement New feature or request label Aug 8, 2023
@matbme matbme marked this pull request as ready for review August 11, 2023 22:18
@matbme matbme merged commit be04c8a into v2 Aug 11, 2023
4 checks passed
@kbdharun kbdharun deleted the kargs branch August 19, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants