Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate server to fastify #116

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

GabsEdits
Copy link
Member

@GabsEdits GabsEdits commented Aug 8, 2024

Reimplementing the Fastify migration from Express. The only difference from this pr and the last one for Fastify is that it's simpler, and easier to read.

For testing I've opened a live server using the production environment to test it fully

Live Server: https://pr.gxbs.me/


Banchmarks

  • Express:

Screenshot 2024-08-08 at 12 36 54

  • Fastify:

Screenshot 2024-08-08 at 12 33 22

Plugin

I've added only one plugin, to avoid it being to complex:

  • Rate Limit: Set to 300, to make sure that everything loads good (lower could make it worse)

@kbdharun kbdharun self-assigned this Aug 8, 2024
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@kbdharun kbdharun merged commit 3e945b4 into Vanilla-OS:main Aug 8, 2024
1 check passed
@GabsEdits GabsEdits deleted the fastify branch August 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants