Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tomjn docker nginx fix #2674

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Tomjn docker nginx fix #2674

merged 3 commits into from
Jun 29, 2023

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Jun 28, 2023

Fixes for Nginx, it seems they were done at the same time as @msaggiorato latest commits in parallel though with a slightly different method.

Also contains shellcheck related fixes

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Jun 28, 2023 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn changed the base branch from develop to docker-provider June 28, 2023 17:43
@tomjn tomjn mentioned this pull request Jun 28, 2023
Merged
4 tasks
@tomjn tomjn merged commit 07f1111 into docker-provider Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomjn