Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VVV specific dockerfile, gets built on provision #2687

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Oct 1, 2023

Moves the dockerfile from pentatonic funk over to VVV, this does centralise things here, though ideally we build this and put it up as an image with a VVV name. I also used [email protected] but that's only slightly less problematic ( is it optional? ).

The other Q is, what can we put in here to save time during the main VVV provisioner that only docker can do? Do we need a compose file to setup Nginx/MariaDB containers and would that mean changing other parts of VVV to make that work? Would all wp-config.php files need to change on docker based setups?

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Oct 1, 2023

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn
Copy link
Member Author

tomjn commented Oct 16, 2023

I'm thinking this could be expanded to execute the main provisioner, and perhaps some of the tools provisioner ( parts that don't use shared/mapped folders at runtime ). Then this could be set on a toggle/switch as a way to build a VVV container for a stable version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant