Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Network check failure and mariadb service failure #2736

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Sep 20, 2024

If a network check fails, try it again without the quiet flag so thatwe can see the issue, also fix the listing of failed checks to show just the failed ones

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

Copy link

update-docs bot commented Sep 20, 2024

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn
Copy link
Member Author

tomjn commented Sep 20, 2024

I was hoping this would yield clues to why the CI was failing on github for #2735 , just my luck that it ends up passing anyway

@tomjn tomjn changed the base branch from develop to better_hook_provisioner_timing September 20, 2024 12:20
@tomjn tomjn marked this pull request as ready for review September 20, 2024 12:20
@tomjn tomjn merged commit 61453bf into better_hook_provisioner_timing Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant