Modified some of the reporting keys and overhauled the wandb reporter #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
reviewed
Nov 15, 2024
…_server_test Fixing infinite base server test
|
Good to go here I think |
emersodb
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature and Fix
Short Description
I noticed an issue where data at the round level was not reported if the wandb reporter step type was step. This was initially the intended behaviour, but we were losing information which wasn't logged at the step level. Restructured the wandb reporter to fix this and also fixed a few things. Additionally I needed to change the metric key for fit_metrics and fit_losses since they were not the same at both the round, epoch and step level. Added some comments to clarify.
A future PR might look into having a single config file that defines all our reporting/logging metrics.
Tests Added
Modified some of the tests to reflect the new reporting keys