Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading peotry lock to include jinja update. #308

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Upgrading peotry lock to include jinja update. #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e856ded
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Dec 23, 2024
5004357
Upgrading peotry lock to include jinja update. This is needed to fix …
emersodb Jan 6, 2025
4b576f6
Merge pull request #306 from VectorInstitute/pre-commit-ci-update-config
emersodb Jan 6, 2025
e4ed736
Trying to fix a version issue with nnunet for the smoke tests
emersodb Jan 6, 2025
011bd89
Merge branch 'dbe/fixing_jinja_vulnerability' of github.com:VectorIns…
emersodb Jan 6, 2025
9412d13
Changing to a non-deprecated numpy float conversion and moving to ins…
emersodb Jan 6, 2025
93e0ed5
Reverting to acvl_utils install until we can move to python 3.11 and …
emersodb Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ repos:
- id: isort

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.13.0
rev: v1.14.0
hooks:
- id: mypy
name: mypy
Expand Down
4 changes: 2 additions & 2 deletions fl4health/parameter_exchange/parameter_packer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ def unpack_parameters(self, packed_parameters: NDArrays) -> Tuple[NDArrays, floa
# The last entry in the parameters list is assumed to be a clipping bound (even if we're evaluating)
split_size = len(packed_parameters) - 1
model_parameters = packed_parameters[:split_size]
clipping_bound = float(packed_parameters[split_size:][0])
return model_parameters, clipping_bound
clipping_bound = packed_parameters[split_size:][0]
return model_parameters, clipping_bound.item()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed to be updated as it was throwing a deprecation error that was killing the smoke tests.



class ParameterPackerAdaptiveConstraint(ParameterPacker[float]):
Expand Down
Loading
Loading