Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contrastive losses #67

Merged
merged 85 commits into from
Nov 9, 2023
Merged

Add contrastive losses #67

merged 85 commits into from
Nov 9, 2023

Conversation

sanaAyrml
Copy link
Collaborator

PR Type

[Feature]

Short Description

Added Cosine Similarity, Contrastive Loss and perFCL Loss for fender experiments.

emersodb
emersodb reviewed Nov 3, 2023
View reviewed changes
research/flamby/utils.py Outdated Show resolved Hide resolved
emersodb
emersodb reviewed Nov 3, 2023
View reviewed changes
research/flamby/utils.py Outdated Show resolved Hide resolved
sanaAyrml
sanaAyrml commented Nov 4, 2023
View reviewed changes
fl4health/clients/fenda_client.py Outdated Show resolved Hide resolved
fl4health/clients/fenda_client.py Show resolved Hide resolved
emersodb
emersodb reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think all of the new changes you made look really good. Just a few additional small comments and then I think we should be good to go

@emersodb emersodb self-requested a review November 9, 2023 13:58
emersodb
emersodb approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. Great addition Sana.

@sanaAyrml sanaAyrml merged commit f38e30e into main Nov 9, 2023
2 checks passed
@sanaAyrml sanaAyrml deleted the Add_contrastive_losses branch November 9, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersodb emersodb emersodb approved these changes

@jewelltaylor jewelltaylor Awaiting requested review from jewelltaylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanaAyrml @emersodb