Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Reference Implementation #24

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

AWS Reference Implementation #24

wants to merge 63 commits into from

Conversation

rjavadi
Copy link
Collaborator

@rjavadi rjavadi commented Nov 8, 2024

This PR adds reference implementation for online and offline inference.

Copy link
Collaborator

@lotif lotif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! And sorry for the delay reviewing it. There are the comments on my first pass through this. Let me know what you think.

reference_implementations/aws/offline/04_lambda.tf Outdated Show resolved Hide resolved
reference_implementations/aws/offline/06_redshift.tf Outdated Show resolved Hide resolved
reference_implementations/aws/offline/08_sqs.tf Outdated Show resolved Hide resolved
reference_implementations/aws/offline/08_sqs.tf Outdated Show resolved Hide resolved
project = "ai-deployment-bootcamp"
region = "us-east-1"
prefix = "poc"
infra_env = "dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work similar to the env var on the GCP implementation (see also here)? i.e. if I change the env to something like env-marcelo I can deploy a whole parallel architecture without affecting whatever has been deployed before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're similar, with the difference that in AWS we don't have separate projects and we can use infra_env and append it to resource names or use it in other properties (e.g. Environment tags) to ensure isolation from other resources.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already being done, or do I need to manually append it in case I need to do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I haven't done it so you need to append your env name to resources

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do it here as well? It was an important part of the GCP implementation as it allows the participants to spin up multiple test pipelines at the same time. Doing it beforehand for them makes it very handy.

Copy link
Collaborator

@lotif lotif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Roya, thanks for implementing it!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants