-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Reference Implementation #24
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! And sorry for the delay reviewing it. There are the comments on my first pass through this. Let me know what you think.
reference_implementations/aws/online/aws_sagemaker/ingest_data_to_fs.py
Outdated
Show resolved
Hide resolved
project = "ai-deployment-bootcamp" | ||
region = "us-east-1" | ||
prefix = "poc" | ||
infra_env = "dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work similar to the env var on the GCP implementation (see also here)? i.e. if I change the env to something like env-marcelo
I can deploy a whole parallel architecture without affecting whatever has been deployed before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they're similar, with the difference that in AWS we don't have separate projects and we can use infra_env and append it to resource names or use it in other properties (e.g. Environment tags) to ensure isolation from other resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already being done, or do I need to manually append it in case I need to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I haven't done it so you need to append your env name to resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do it here as well? It was an important part of the GCP implementation as it allows the participants to spin up multiple test pipelines at the same time. Doing it beforehand for them makes it very handy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Roya, thanks for implementing it!!!
This PR adds reference implementation for online and offline inference.