Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Fix SignatureCheckerLib Natspec #1137

Merged
merged 2 commits into from
Oct 31, 2024
Merged

📝 Fix SignatureCheckerLib Natspec #1137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa818cc
Fix SignatureCheckerLib Natspec
Vectorized Oct 31, 2024
bf1941d
T
Vectorized Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/utils/SignatureCheckerLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ library SignatureCheckerLib {
/*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

/// @dev Returns whether `signature` is valid for `signer` and `hash`.
/// If `signer` is a smart contract, the signature is validated with ERC1271.
/// Otherwise, the signature is validated with `ECDSA.recover`.
/// First, it will try to validate with `ecrecover`, and if the validation fails,
/// it will try to validate with ERC1271 on `signer`.
function isValidSignatureNow(address signer, bytes32 hash, bytes memory signature)
internal
view
Expand Down Expand Up @@ -115,8 +115,8 @@ library SignatureCheckerLib {
}

/// @dev Returns whether `signature` is valid for `signer` and `hash`.
/// If `signer` is a smart contract, the signature is validated with ERC1271.
/// Otherwise, the signature is validated with `ECDSA.recover`.
/// First, it will try to validate with `ecrecover`, and if the validation fails,
/// it will try to validate with ERC1271 on `signer`.
function isValidSignatureNowCalldata(address signer, bytes32 hash, bytes calldata signature)
internal
view
Expand Down Expand Up @@ -203,8 +203,8 @@ library SignatureCheckerLib {
}

/// @dev Returns whether the signature (`r`, `vs`) is valid for `signer` and `hash`.
/// If `signer` is a smart contract, the signature is validated with ERC1271.
/// Otherwise, the signature is validated with `ECDSA.recover`.
/// First, it will try to validate with `ecrecover`, and if the validation fails,
/// it will try to validate with ERC1271 on `signer`.
function isValidSignatureNow(address signer, bytes32 hash, bytes32 r, bytes32 vs)
internal
view
Expand Down Expand Up @@ -269,8 +269,8 @@ library SignatureCheckerLib {
}

/// @dev Returns whether the signature (`v`, `r`, `s`) is valid for `signer` and `hash`.
/// If `signer` is a smart contract, the signature is validated with ERC1271.
/// Otherwise, the signature is validated with `ECDSA.recover`.
/// First, it will try to validate with `ecrecover`, and if the validation fails,
/// it will try to validate with ERC1271 on `signer`.
function isValidSignatureNow(address signer, bytes32 hash, uint8 v, bytes32 r, bytes32 s)
internal
view
Expand Down