Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Optimize WebAuthn for struct case #1157

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

Vectorized
Copy link
Owner

Description

We'll use the struct case most often.
If requireUserVerification is false, then it will be optional.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Nov 7, 2024

Gas Snapshot Comparison Report

Generated at commit : 01bbb9b, Compared to commit : fef3cd7

Contract Name Test Name Main Gas PR Gas Diff
WebAuthnTest testChrome() 193675 193575 -100
testSafari() 193981 193881 -100
test__codesize() 10262 10229 -33

@Vectorized Vectorized merged commit 65823dd into main Nov 7, 2024
11 of 15 checks passed
@Vectorized Vectorized deleted the webauthn-refactor-2 branch November 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant