Replace hard-coded timestamps with the vars. StartTime/EndTime #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Generic.Client.Stats plotting VQL suggestions uses two hard-coded timestamps and thus no longer works. Instead, use the StartTime/EndTime variables.
scudette
pushed a commit
that referenced
this pull request
Nov 4, 2024
The Generic.Client.Stats plotting VQL suggestion uses two hard-coded timestamps and thus no longer works (especially since the timestamps are both a long time ago in the past). Instead, use the StartTime/EndTime variables. It could be useful to keep two hard-coded timestamps in LET expressions, but as a comment, so that the user can easily override the time range after the notebook has been created.
scudette
pushed a commit
that referenced
this pull request
Nov 4, 2024
The Generic.Client.Stats plotting VQL suggestion uses two hard-coded timestamps and thus no longer works (especially since the timestamps are both a long time ago in the past). Instead, use the StartTime/EndTime variables. It could be useful to keep two hard-coded timestamps in LET expressions, but as a comment, so that the user can easily override the time range after the notebook has been created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Generic.Client.Stats plotting VQL suggestion uses two hard-coded timestamps and thus no longer works (especially since the timestamps are both a long time ago in the past). Instead, use the StartTime/EndTime variables.
It could be useful to keep two hard-coded timestamps in LET expressions, but as a comment, so that the user can easily override the time range after the notebook has been created.