Skip to content

Commit

Permalink
Delete RNNoise - Krisp is now on web, so this is obsolete
Browse files Browse the repository at this point in the history
  • Loading branch information
@Vendicated
Vendicated committed Oct 25, 2023
1 parent 8054a1e commit 871edb0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 300 deletions.
21 changes: 0 additions & 21 deletions src/plugins/rnnoise.web/icons.tsx
View file

This file was deleted.

250 changes: 0 additions & 250 deletions src/plugins/rnnoise.web/index.tsx
View file

This file was deleted.

29 changes: 0 additions & 29 deletions src/plugins/rnnoise.web/styles.css
View file

This file was deleted.

6 comments on commit 871edb0

@xenorio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! I know you guys are very much busy with fixing things up right now, so don't let me stress you out more, but this commit is like really not cool...

Yes, the web version does have Krisp. However, Krisp is really buggy, at least on my system (Linux, Pipewire, Firefox). I've been told that I sound like Bugs Bunny whenever I enable Krisp, which is not the case with RNNoise. So this commit effectively takes away the only viable noise reduction for me and most likely a bunch of other people too.

@lillithkt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shut

@Vendicated
Copy link
Owner Author

@Vendicated Vendicated commented on 871edb0 Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might bring it back in the future if there is demand, but even its dev told me to remove it (even before it broke), so it's removed for now. it would need a partial rewrite to have a better integration (and not show both krisp and rnnoise)

@Curve
Copy link

@Curve Curve commented on 871edb0 Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! I know you guys are very much busy with fixing things up right now, so don't let me stress you out more, but this commit is like really not cool...

Yes, the web version does have Krisp. However, Krisp is really buggy, at least on my system (Linux, Pipewire, Firefox). I've been told that I sound like Bugs Bunny whenever I enable Krisp, which is not the case with RNNoise. So this commit effectively takes away the only viable noise reduction for me and most likely a bunch of other people too.

You can also use the Noise Reduction on a system level (especially on pipewire)

@xenorio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might bring it back in the future if there is demand, but even its dev told me to remove it (even before it broke)

Welp, I guess this is my contribution to demand then, just wanted to let you know ^^

@Vendicated
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking in #1866 - you can always contribute this yourself if you would like to see it soon

Please sign in to comment.