feat(plugin): SwitchProfileButton #3137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, I love the idea! |
Vendicated
reviewed
Jan 15, 2025
| variant="text-xs/medium" | ||
| >{props.subtext}</Text> | ||
| </>} | ||
| aria-label={false} |
There was a problem hiding this comment.
This is how Discord does it for the other buttons there. I am aware that ReviewDB does not do it this way.
There was a problem hiding this comment.
I went digging again to find where I took this code from and it looks like I stole it from this component, and it turns out I didn't steal all of the code
(from module 475413)
Now that I've looked at it, I agree that this can be improved, but I'm unsure as to how I should improve it.
I can't use the actual component for this as the aria-label can't be set separately, which is what I need to do as the tooltip text isn't a string.
Vendicated
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the View Main/Server Profile button out of the overflow menu
Some code was copied from ReviewDB
How it works:
Replaces the MenuItem components with the button, props are reused as-is by the button component
Moves the item out of the overflow menu component props and into the row of buttons
Suggestions for a different icon are welcome